Song Jiacheng has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20600 )

Change subject: KUDU-3486 Periodically send tombstoned replica report to delete 
it.
......................................................................


Patch Set 20:

(1 comment)

> Patch Set 20:
>
> (2 comments)

Thanks for the review.

http://gerrit.cloudera.org:8080/#/c/20600/20/src/kudu/tserver/heartbeater.cc
File src/kudu/tserver/heartbeater.cc:

http://gerrit.cloudera.org:8080/#/c/20600/20/src/kudu/tserver/heartbeater.cc@110
PS20, Line 110: 
DEFINE_int32(tserver_send_tombstoned_tablets_report_inteval_secs, 21600,
              :              "Time interval in seconds of sending a incremental 
tablets report "
              :              "to delete the tombstoned replicas whose tablets 
had already been "
              :              "deleted. Turn off this by setting it to a value 
less than 0.");
> nit: Also need to mention that if this interval is set to less than the hea
Done



--
To view, visit http://gerrit.cloudera.org:8080/20600
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I92d3b3e44f49ad24a95fa10f351c6bd55c6eca7b
Gerrit-Change-Number: 20600
Gerrit-PatchSet: 20
Gerrit-Owner: Song Jiacheng <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Song Jiacheng <[email protected]>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <[email protected]>
Gerrit-Reviewer: Yifan Zhang <[email protected]>
Gerrit-Comment-Date: Wed, 06 Dec 2023 09:14:21 +0000
Gerrit-HasComments: Yes

Reply via email to