Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20600 )
Change subject: KUDU-3486 Periodically send tombstoned replica report to delete it. ...................................................................... Patch Set 20: (2 comments) http://gerrit.cloudera.org:8080/#/c/20600/20/src/kudu/tserver/heartbeater.cc File src/kudu/tserver/heartbeater.cc: http://gerrit.cloudera.org:8080/#/c/20600/20/src/kudu/tserver/heartbeater.cc@110 PS20, Line 110: DEFINE_int32(tserver_send_tombstoned_tablets_report_inteval_secs, 21600, : "Time interval in seconds of sending a incremental tablets report " : "to delete the tombstoned replicas whose tablets had already been " : "deleted. Turn off this by setting it to a value less than 0."); nit: Also need to mention that if this interval is set to less than the heartbeat interval, the tablets report will only be sent at the heartbeat interval. http://gerrit.cloudera.org:8080/#/c/20600/20/src/kudu/tserver/ts_tablet_manager.cc File src/kudu/tserver/ts_tablet_manager.cc: http://gerrit.cloudera.org:8080/#/c/20600/20/src/kudu/tserver/ts_tablet_manager.cc@1794 PS20, Line 1794: for (const auto& entry : tablet_map_) { : if (entry.second->data_state() == tablet::TABLET_DATA_TOMBSTONED) { : to_report.push_back(entry.second); : } : } > After the replica gets tombstoned, there might be very long time before its 'the tombstoned replica will only be reported in the next heartbeat.' Right. So that means tombstoned should not be removed from 'dirty_tablets_' until they are deleted. And we need to process these tombstoned tablets every heartbeat request. Compared with the current approach, I'm good with iterating all the tablets every 6 hours. -- To view, visit http://gerrit.cloudera.org:8080/20600 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I92d3b3e44f49ad24a95fa10f351c6bd55c6eca7b Gerrit-Change-Number: 20600 Gerrit-PatchSet: 20 Gerrit-Owner: Song Jiacheng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Song Jiacheng <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Thu, 30 Nov 2023 04:16:20 +0000 Gerrit-HasComments: Yes
