Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20736 )
Change subject: Fix CountOnes() function ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/20736/1/src/kudu/gutil/bits.h File src/kudu/gutil/bits.h: http://gerrit.cloudera.org:8080/#/c/20736/1/src/kudu/gutil/bits.h@19 PS1, Line 19: return static_cast<int>((((n + (n >> 4)) & 0x0F0F0F0F) * 0x01010101) >> 24); I tested it for every possible uint32 value against: static int CountOnesBasic(unsigned int n) { int res = 0; while(n) { res += n % 2; n /=2; } return res; } Now it works. -- To view, visit http://gerrit.cloudera.org:8080/20736 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia4b78b5c1df9547548fc7980cec4b84349e868bc Gerrit-Change-Number: 20736 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Martonka <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Tue, 28 Nov 2023 22:27:33 +0000 Gerrit-HasComments: Yes
