Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20736 )
Change subject: [arm64] Fix CountOnes() function ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/20736/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20736/2//COMMIT_MSG@7 PS2, Line 7: Fix CountOnes() function > Out of curiosity - did this issue manifest into some failure? bitmap-test TestBitMap.TestIteration was failing. inline void ForEachBit(...) ub bitmap.h has int tot_count = Bits::CountOnes64withPopcount(w); in line 216. This returned 33686278 instead of 6. It also caused the test to fail really slow, because it prints this array (filled with "64") to std::cout. This function (ForEachSetBit) is also used in rowlock.cc, but perf test runs fine, I don't know what exactly uses the corresponding function. -- To view, visit http://gerrit.cloudera.org:8080/20736 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia4b78b5c1df9547548fc7980cec4b84349e868bc Gerrit-Change-Number: 20736 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Martonka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Thu, 30 Nov 2023 09:28:21 +0000 Gerrit-HasComments: Yes
