Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20736 )
Change subject: [arm64] Fix CountOnes() function ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/20736/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20736/2//COMMIT_MSG@9 PS2, Line 9: arms nit: ARM http://gerrit.cloudera.org:8080/#/c/20736/2//COMMIT_MSG@11 PS2, Line 11: For some reason ULL sufix was added to 2 masks, That was my mistake -- I was trying to address ASAN warnings when running tests on aarch64. I thought if no tests are broken, then it still works as expected, but I was wrong. Thank you for the fix! http://gerrit.cloudera.org:8080/#/c/20736/2/src/kudu/gutil/bits.h File src/kudu/gutil/bits.h: http://gerrit.cloudera.org:8080/#/c/20736/2/src/kudu/gutil/bits.h@16 PS2, Line 16: static int CountOnes(uint32 n) { To quell UBSAN warnings, will it be necessary to add ATTRIBUTE_NO_SANITIZE_INTEGER for this function? -- To view, visit http://gerrit.cloudera.org:8080/20736 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia4b78b5c1df9547548fc7980cec4b84349e868bc Gerrit-Change-Number: 20736 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Martonka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Wed, 29 Nov 2023 01:03:07 +0000 Gerrit-HasComments: Yes
