Hello Tidy Bot, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20739
to look at the new patch set (#2).
Change subject: KUDU-3524 Fix core of sending keep-alive requests periodically
......................................................................
KUDU-3524 Fix core of sending keep-alive requests periodically
Currently, calling the interface StartKeepAlivePeriodically()
in kudu client will core. Because this interface uses PeriodicTimer
to send keep-alive requests periodically, and PeriodicTimer uses
reactor thread to do it. Reactor thread does not allow to wait,
see the funciton ReactorThread::RunThread(). But sending keep-alive
requests uses the synchronous interface ScannerKeepAlive(), which
will wait for the response.
This patch uses ScannerKeepAliveAysnc(), a asynchronous interface
to send keep-avlie requests to avoid this problem.
Change-Id: I130db970a091cdf7689245a79dc4ea445d1f739f
---
M src/kudu/client/scanner-internal.cc
M src/kudu/client/scanner-internal.h
2 files changed, 35 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/39/20739/2
--
To view, visit http://gerrit.cloudera.org:8080/20739
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I130db970a091cdf7689245a79dc4ea445d1f739f
Gerrit-Change-Number: 20739
Gerrit-PatchSet: 2
Gerrit-Owner: Wang Xixu <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
