Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/20739 )
Change subject: KUDU-3524 Fix core of sending keep-alive requests periodically ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/20739/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20739/2//COMMIT_MSG@10 PS2, Line 10: in kudu client will core. Does kudu client fail with error intermittently? If yes, could you also add more details on why, if possible. http://gerrit.cloudera.org:8080/#/c/20739/2//COMMIT_MSG@13 PS2, Line 13: funciton nit: function http://gerrit.cloudera.org:8080/#/c/20739/2/src/kudu/client/scanner-internal.cc File src/kudu/client/scanner-internal.cc: http://gerrit.cloudera.org:8080/#/c/20739/2/src/kudu/client/scanner-internal.cc@125 PS2, Line 125: there nit: remove "there" http://gerrit.cloudera.org:8080/#/c/20739/2/src/kudu/client/scanner-internal.cc@128 PS2, Line 128: ScannerKeepAliveAsync Can you please point me to definition of ScannerKeepAliveAsync? -- To view, visit http://gerrit.cloudera.org:8080/20739 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I130db970a091cdf7689245a79dc4ea445d1f739f Gerrit-Change-Number: 20739 Gerrit-PatchSet: 2 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Comment-Date: Wed, 29 Nov 2023 15:48:57 +0000 Gerrit-HasComments: Yes
