Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20739 )
Change subject: KUDU-3524 Fix core of sending keep-alive requests periodically ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/20739/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20739/3//COMMIT_MSG@10 PS3, Line 10: will core > Could you please add a unit test to reproduce this? And make sure the fix w +1 http://gerrit.cloudera.org:8080/#/c/20739/3/src/kudu/client/scanner-internal.cc File src/kudu/client/scanner-internal.cc: http://gerrit.cloudera.org:8080/#/c/20739/3/src/kudu/client/scanner-internal.cc@104 PS3, Line 104: delete this; Should we also log some error messages? See the implementation of 'CloseCallback' for an example. -- To view, visit http://gerrit.cloudera.org:8080/20739 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I130db970a091cdf7689245a79dc4ea445d1f739f Gerrit-Change-Number: 20739 Gerrit-PatchSet: 3 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Sat, 09 Dec 2023 02:40:37 +0000 Gerrit-HasComments: Yes
