Hello Yifan Zhang, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20744
to look at the new patch set (#2).
Change subject: more strict check for [un]setenv() return code
......................................................................
more strict check for [un]setenv() return code
Even if setenv() and unsetenv() function expected to almost never fail
with the current code as per documentation [1], it still makes sense
to check for their return code. This patch updates the call sites
of these functions accordingly.
I also addressed a few warnings that ClangTidy produced
on the updated code.
[1] https://man7.org/linux/man-pages/man3/setenv.3.html
Change-Id: I8257bc4367b3fdf0cda5171de9b39c8d8b87fba9
---
M src/kudu/benchmarks/tpch/tpch_real_world.cc
M src/kudu/client/client-test.cc
M src/kudu/rpc/negotiation-test.cc
M src/kudu/security/init.cc
M src/kudu/security/test/mini_kdc.cc
M src/kudu/server/webserver-test.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/util/subprocess.cc
M src/kudu/util/test_util.cc
M src/kudu/util/test_util.h
10 files changed, 42 insertions(+), 34 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44/20744/2
--
To view, visit http://gerrit.cloudera.org:8080/20744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8257bc4367b3fdf0cda5171de9b39c8d8b87fba9
Gerrit-Change-Number: 20744
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <[email protected]>
