Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20744 )
Change subject: more strict check for [un]setenv() return code ...................................................................... more strict check for [un]setenv() return code Even if setenv() and unsetenv() function expected to almost never fail with the current code as per documentation [1], it still makes sense to check for their return code. This patch updates the call sites of these functions accordingly. I also addressed a few warnings that ClangTidy produced on the updated code. [1] https://man7.org/linux/man-pages/man3/setenv.3.html Change-Id: I8257bc4367b3fdf0cda5171de9b39c8d8b87fba9 Reviewed-on: http://gerrit.cloudera.org:8080/20744 Reviewed-by: Abhishek Chennaka <[email protected]> Reviewed-by: Mahesh Reddy <[email protected]> Tested-by: Kudu Jenkins Reviewed-by: Yifan Zhang <[email protected]> --- M src/kudu/benchmarks/tpch/tpch_real_world.cc M src/kudu/client/client-test.cc M src/kudu/rpc/negotiation-test.cc M src/kudu/security/init.cc M src/kudu/security/test/mini_kdc.cc M src/kudu/server/webserver-test.cc M src/kudu/tools/kudu-tool-test.cc M src/kudu/util/subprocess.cc M src/kudu/util/test_util.cc M src/kudu/util/test_util.h 10 files changed, 42 insertions(+), 34 deletions(-) Approvals: Abhishek Chennaka: Looks good to me, approved Mahesh Reddy: Looks good to me, but someone else must approve Kudu Jenkins: Verified Yifan Zhang: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/20744 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I8257bc4367b3fdf0cda5171de9b39c8d8b87fba9 Gerrit-Change-Number: 20744 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]>
