Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20744 )

Change subject: more strict check for [un]setenv() return code
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/20744/1/src/kudu/security/init.cc
File src/kudu/security/init.cc:

http://gerrit.cloudera.org:8080/#/c/20744/1/src/kudu/security/init.cc@519
PS1, Line 519:   g_kinit_ctx = new KinitContext;
> Is this change needed?
Whoops: nope, this isn't not.  This shouldn't be a part of this changelist.



--
To view, visit http://gerrit.cloudera.org:8080/20744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8257bc4367b3fdf0cda5171de9b39c8d8b87fba9
Gerrit-Change-Number: 20744
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <[email protected]>
Gerrit-Comment-Date: Mon, 04 Dec 2023 17:54:53 +0000
Gerrit-HasComments: Yes

Reply via email to