Wang Xixu has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20739 )

Change subject: KUDU-3524 Fix crash when sending periodic keep-alive requests
......................................................................


Patch Set 6:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/20739/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/20739/2//COMMIT_MSG@10
PS2, Line 10: StartKeepAlivePeriodicall
> Thanks for clarification. Have you added details on why failure is intermit
Oh, sorry. I take `intermittently` as `immediately`. In fact, in macOS, Kudu 
client fails every time. I find this crash only happens on macOS.


http://gerrit.cloudera.org:8080/#/c/20739/5//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/20739/5//COMMIT_MSG@10
PS5, Line 10: StartKeepAlivePeriodically(), see KUDU-3524 for details. That's
> nit: KUDU-3542 is incorrect issue id.
Done



--
To view, visit http://gerrit.cloudera.org:8080/20739
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I130db970a091cdf7689245a79dc4ea445d1f739f
Gerrit-Change-Number: 20739
Gerrit-PatchSet: 6
Gerrit-Owner: Wang Xixu <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Ashwani Raina <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <[email protected]>
Gerrit-Reviewer: Yifan Zhang <[email protected]>
Gerrit-Reviewer: Yingchun Lai <[email protected]>
Gerrit-Reviewer: Ádám Bakai <[email protected]>
Gerrit-Comment-Date: Fri, 15 Dec 2023 01:43:42 +0000
Gerrit-HasComments: Yes

Reply via email to