Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/20739 )
Change subject: KUDU-3524 Fix crash when sending periodic keep-alive requests ...................................................................... Patch Set 5: (10 comments) http://gerrit.cloudera.org:8080/#/c/20739/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20739/4//COMMIT_MSG@7 PS4, Line 7: Fix crash when sending periodic keep-alive requests > How about: Done http://gerrit.cloudera.org:8080/#/c/20739/4//COMMIT_MSG@9 PS4, Line 9: Currently, Kudu client applications on macOS crash upon calling : StartKeepAlivePeriodically(), see KUDU-3542 for details. Th > how about: Done http://gerrit.cloudera.org:8080/#/c/20739/4//COMMIT_MSG@11 PS4, Line 11: because a PeriodicTimer was used to send keep-alive requests in : a synchronous manner, while attempting to wait for the response : on a reactor thread. However, reactor threads do not allow for : waiting. : : This patch uses ' > That's because a PeriodicTimer was used to send keep-alive requests in a sy Done http://gerrit.cloudera.org:8080/#/c/20739/4//COMMIT_MSG@18 PS4, Line 18: > an Done http://gerrit.cloudera.org:8080/#/c/20739/4/src/kudu/client/scanner-internal.h File src/kudu/client/scanner-internal.h: http://gerrit.cloudera.org:8080/#/c/20739/4/src/kudu/client/scanner-internal.h@289 PS4, Line 289: p > style nit: indent should be 1 space from the start of the outer 'struct' sc Done http://gerrit.cloudera.org:8080/#/c/20739/4/src/kudu/client/scanner-internal.h@290 PS4, Line 290: de > nit: could use '= default' here as well? Done http://gerrit.cloudera.org:8080/#/c/20739/4/src/kudu/client/scanner-internal.cc File src/kudu/client/scanner-internal.cc: http://gerrit.cloudera.org:8080/#/c/20739/4/src/kudu/client/scanner-internal.cc@105 PS4, Line 105: bstitute("Failed to send keep-alive request: $0", : controller.status().To > nit: consider using Substitute() to format the message: Done http://gerrit.cloudera.org:8080/#/c/20739/4/src/kudu/client/scanner-internal.cc@107 PS4, Line 107: } > nit: The indentation is incorrect. Done http://gerrit.cloudera.org:8080/#/c/20739/4/src/kudu/client/scanner-internal.cc@126 PS4, Line 126: // 'cb' deletes itself upon completion. > Could please you add a comment before this line: Done http://gerrit.cloudera.org:8080/#/c/20739/4/src/kudu/client/scanner-internal.cc@130 PS4, Line 130: waiting, so calling ScannerKeepAliveAsync() : // instead of ScannerKeepAlive(). > nit: I guess you could omit this long explanation since the first part of t Done -- To view, visit http://gerrit.cloudera.org:8080/20739 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I130db970a091cdf7689245a79dc4ea445d1f739f Gerrit-Change-Number: 20739 Gerrit-PatchSet: 5 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Thu, 14 Dec 2023 07:52:53 +0000 Gerrit-HasComments: Yes
