Hello Tidy Bot, Alexey Serbin, Ashwani Raina, Yingchun Lai, Yifan Zhang, Kudu
Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20739
to look at the new patch set (#5).
Change subject: KUDU-3524 Fix crash when sending periodic keep-alive requests
......................................................................
KUDU-3524 Fix crash when sending periodic keep-alive requests
Currently, Kudu client applications on macOS crash upon calling
StartKeepAlivePeriodically(), see KUDU-3542 for details. That's
because a PeriodicTimer was used to send keep-alive requests in
a synchronous manner, while attempting to wait for the response
on a reactor thread. However, reactor threads do not allow for
waiting.
This patch uses 'ScannerKeepAliveAysnc()', an asynchronous interface
to send keep-alive requests to avoid this problem.
Change-Id: I130db970a091cdf7689245a79dc4ea445d1f739f
---
M src/kudu/client/scanner-internal.cc
M src/kudu/client/scanner-internal.h
2 files changed, 40 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/39/20739/5
--
To view, visit http://gerrit.cloudera.org:8080/20739
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I130db970a091cdf7689245a79dc4ea445d1f739f
Gerrit-Change-Number: 20739
Gerrit-PatchSet: 5
Gerrit-Owner: Wang Xixu <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Ashwani Raina <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <[email protected]>
Gerrit-Reviewer: Yifan Zhang <[email protected]>
Gerrit-Reviewer: Yingchun Lai <[email protected]>
