Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21244 )

Change subject: [WIP] KUDU-3518: Fix unexpected new predicate
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/21244/1//COMMIT_MSG
Commit Message:

PS1:
I haven't looked closely yet, but one thing that stood out was the absence of a 
test that reproduces the bug.  I guess it would be much easier to reason about 
alternative ways to address this once there is a test scenario that reproduces 
the issue: at least it will confirm the diagnosis and will provide more hints 
on alternative approaches.

Thank you!


http://gerrit.cloudera.org:8080/#/c/21244/1/src/kudu/common/scan_spec.cc
File src/kudu/common/scan_spec.cc:

http://gerrit.cloudera.org:8080/#/c/21244/1/src/kudu/common/scan_spec.cc@284
PS1, Line 284: void (const Schema& schema, Arena* arena)
What's this?



--
To view, visit http://gerrit.cloudera.org:8080/21244
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I220df7ec1b4f95726c913a19125f4647267d12b1
Gerrit-Change-Number: 21244
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Yifan Zhang <[email protected]>
Gerrit-Reviewer: Yingchun Lai <[email protected]>
Gerrit-Reviewer: Zoltan Chovan <[email protected]>
Gerrit-Comment-Date: Fri, 05 Apr 2024 18:17:35 +0000
Gerrit-HasComments: Yes

Reply via email to