Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21244 )
Change subject: KUDU-3518: Fix the unexpected scan predicate ...................................................................... Patch Set 2: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/21244/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21244/2//COMMIT_MSG@9 PS2, Line 9: has have http://gerrit.cloudera.org:8080/#/c/21244/2//COMMIT_MSG@10 PS2, Line 10: patches patch http://gerrit.cloudera.org:8080/#/c/21244/2//COMMIT_MSG@13 PS2, Line 13: The issue happens when the equality predicate on a primary key : column is a string and has extra NULL characters appended to the : end of upper bound of the ScanSpec resulting in the addition of : a new predicate (IS NOT NULL) on the next primary key column (if : it exists) and causing the scan failure. This occurs when a : specific code path is taken which needs compactions/flushes to : have taken place complicating the regular C++ tests. This looks a bit cryptic. Since this patch doesn't include a test to reproduce the issue, maybe it's not worth it adding too many details? Maybe, shorten this to something like: This patch removes NON-NULL predicates on primary columns implicitly added by ScanSpec::LiftPrimaryKeyBounds(), calling ScanSpec::OptimizeScan() while optimizing InList scan predicates at the DRS level. That's similar to what's done be optimizing the InList predicates based on tablet PK bounds at a higher level. -- To view, visit http://gerrit.cloudera.org:8080/21244 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I220df7ec1b4f95726c913a19125f4647267d12b1 Gerrit-Change-Number: 21244 Gerrit-PatchSet: 2 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Tue, 16 Apr 2024 03:26:16 +0000 Gerrit-HasComments: Yes
