Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21244 )
Change subject: KUDU-3518: Fix the unexpected scan predicate ...................................................................... Patch Set 3: Verified+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/21244/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21244/3//COMMIT_MSG@14 PS3, Line 14: nit for here and below: please remove the trailing spaces http://gerrit.cloudera.org:8080/#/c/21244/3//COMMIT_MSG@13 PS3, Line 13: NON-NULL predicates on primary columns implicitly : added by ScanSpec::LiftPrimaryKeyBounds() > Yes, this function does add implicit NON_NULL predicates. But I'm still not Abhishek and I have looked at a reproduction scenario, but it was built using with real data. We have verified that this patch fixes the issue: the bug no longer triggers with this code in place. Putting together a reproduction scenario with minimal amount of data seems to be a non-trivial task, though. This patch on itself might be considered as an extra optimization for the InList predicate evaluation at the DRS level. -- To view, visit http://gerrit.cloudera.org:8080/21244 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I220df7ec1b4f95726c913a19125f4647267d12b1 Gerrit-Change-Number: 21244 Gerrit-PatchSet: 3 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Tue, 16 Apr 2024 15:23:21 +0000 Gerrit-HasComments: Yes
