Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21282 )
Change subject: [CMakeLists] Make kudu_test_main static ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/21282/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21282/1//COMMIT_MSG@14 PS1, Line 14: This happens in ubuntu 22.04 test runs Could you provide a set of instructions to reproduce the issue? I could not see it happening on my tests, and I'm curious whether this change will make the binaries now failing elsewhere due to the modification of the loading chain. Frankly, this manual intervention into the loader's realm seems a bit strange, so I'm hesitant to give +1 or +2 to this patch without higher level of confidence that it's fixing a real issue, and fixing it the correct way. -- To view, visit http://gerrit.cloudera.org:8080/21282 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0dfeb1fa04ed91e95fd1f8d789f020dd44289fea Gerrit-Change-Number: 21282 Gerrit-PatchSet: 1 Gerrit-Owner: Ádám Bakai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Wed, 10 Apr 2024 18:39:08 +0000 Gerrit-HasComments: Yes
