Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21282 )
Change subject: [CMakeLists] Make kudu_test_main static ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/21282/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21282/1//COMMIT_MSG@10 PS1, Line 10: loading chain Please use "library search order" not "loading chain". That's the correct terminology. You could also add a few sentences about what the original code does (wraps dlopen and dlclose to prevent a potential deadlock during unwind stack resolve???) Also mention that this is just a best effort fix for an already known issue, and we don't really care because release is statically linked (unwind_safeness.cc line 117: "given that dynamic linkage isn't used in production anyway") http://gerrit.cloudera.org:8080/#/c/21282/1/src/kudu/util/CMakeLists.txt File src/kudu/util/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/21282/1/src/kudu/util/CMakeLists.txt@469 PS1, Line 469: add_library(kudu_test_main STATIC The static keyword alone should solve the issue, or am I missing something? no need to reorder the libs below. Wont static linking tests kill the purpose of "-DKUDU_LINK=dynamic" ? -- To view, visit http://gerrit.cloudera.org:8080/21282 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0dfeb1fa04ed91e95fd1f8d789f020dd44289fea Gerrit-Change-Number: 21282 Gerrit-PatchSet: 1 Gerrit-Owner: Ádám Bakai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Thu, 11 Apr 2024 07:27:19 +0000 Gerrit-HasComments: Yes
