Zoltan Martonka has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21282 )

Change subject: [CMakeLists] Make kudu_test_main static
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/21282/1/src/kudu/util/CMakeLists.txt
File src/kudu/util/CMakeLists.txt:

http://gerrit.cloudera.org:8080/#/c/21282/1/src/kudu/util/CMakeLists.txt@469
PS1, Line 469:   add_library(kudu_test_main STATIC
> The static keyword alone should solve the issue, or am I missing something?
The real question is: How much will this affect TSAN/ASAN build time/disk space?



--
To view, visit http://gerrit.cloudera.org:8080/21282
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0dfeb1fa04ed91e95fd1f8d789f020dd44289fea
Gerrit-Change-Number: 21282
Gerrit-PatchSet: 1
Gerrit-Owner: Ádám Bakai <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Zoltan Martonka <[email protected]>
Gerrit-Comment-Date: Thu, 11 Apr 2024 07:30:01 +0000
Gerrit-HasComments: Yes

Reply via email to