Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/21920 )
Change subject: [WIP] Implement path parameter handling in webserver ...................................................................... Patch Set 1: (4 comments) looks good at a first glance, but needs tests also some nits http://gerrit.cloudera.org:8080/#/c/21920/1/src/kudu/server/webserver.cc File src/kudu/server/webserver.cc: http://gerrit.cloudera.org:8080/#/c/21920/1/src/kudu/server/webserver.cc@600 PS1, Line 600: nit:whitespace http://gerrit.cloudera.org:8080/#/c/21920/1/src/kudu/server/webserver.cc@611 PS1, Line 611: if (handler_segments[i][0] == '<' && handler_segments[i][handler_segments[i].size() - 1] == '>') { nit:line too long http://gerrit.cloudera.org:8080/#/c/21920/1/src/kudu/server/webserver.cc@612 PS1, Line 612: nit:whitespace http://gerrit.cloudera.org:8080/#/c/21920/1/src/kudu/server/webserver.cc@640 PS1, Line 640: handler = it->second; nit:ident -- To view, visit http://gerrit.cloudera.org:8080/21920 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id2085c55d3b86985c87c5fd5a8b48568f8e6fa63 Gerrit-Change-Number: 21920 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Thu, 10 Oct 2024 12:49:33 +0000 Gerrit-HasComments: Yes
