Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/21920 )
Change subject: [WIP] Implement path parameter handling in webserver ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/21920/2/src/kudu/server/default_path_handlers.cc File src/kudu/server/default_path_handlers.cc: http://gerrit.cloudera.org:8080/#/c/21920/2/src/kudu/server/default_path_handlers.cc@446 PS2, Line 446: PrerenderedWebResponse Why does this need to be a PrerenderedWebResponse? Based on the output, there won't be any HTML code to be rendered. Same for the next method. http://gerrit.cloudera.org:8080/#/c/21920/2/src/kudu/server/default_path_handlers.cc@489 PS2, Line 489: RegisterPrerenderedPathHandler Could this be simply RegisterPathHandler? http://gerrit.cloudera.org:8080/#/c/21920/2/src/kudu/server/default_path_handlers.cc@491 PS2, Line 491: RegisterPrerenderedPathHandler Could this be simply RegisterPathHandler? http://gerrit.cloudera.org:8080/#/c/21920/2/src/kudu/server/webserver-test.cc File src/kudu/server/webserver-test.cc: http://gerrit.cloudera.org:8080/#/c/21920/2/src/kudu/server/webserver-test.cc@129 PS2, Line 129: AddTestPathHandlers(server_.get()); nit: keep the empty new line for spacing -- To view, visit http://gerrit.cloudera.org:8080/21920 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id2085c55d3b86985c87c5fd5a8b48568f8e6fa63 Gerrit-Change-Number: 21920 Gerrit-PatchSet: 2 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Mon, 14 Oct 2024 13:03:27 +0000 Gerrit-HasComments: Yes
