Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/21920 )
Change subject: [WIP] Implement path parameter handling in webserver ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/21920/2/src/kudu/server/default_path_handlers.h File src/kudu/server/default_path_handlers.h: http://gerrit.cloudera.org:8080/#/c/21920/2/src/kudu/server/default_path_handlers.h@36 PS2, Line 36: void AddTestPathHandlers(Webserver* webserver); It might be better to create a test only path handler, to avoid webserver bloating. There is an example already that creates a test webserver setup, and registeres a path handler: https://github.com/apache/kudu/blob/446861c68cb3cc5e8ef8caaadf7d8eefc2ec1387/src/kudu/util/jwt-util-test.cc#L844-L898 I hope this helps. -- To view, visit http://gerrit.cloudera.org:8080/21920 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id2085c55d3b86985c87c5fd5a8b48568f8e6fa63 Gerrit-Change-Number: 21920 Gerrit-PatchSet: 2 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Mon, 14 Oct 2024 13:03:14 +0000 Gerrit-HasComments: Yes
