Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21956 )
Change subject: KUDU-613: Fix minor metrics related bug ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/21956/3/src/kudu/util/slru_cache-test.cc File src/kudu/util/slru_cache-test.cc: PS3: Thanks a lot for updating the scenario accordingly! http://gerrit.cloudera.org:8080/#/c/21956/3/src/kudu/util/slru_cache-test.cc@301 PS3, Line 301: static_cast nit: consider using down_cast<> and asserting on the non-null of the result for safer down-casting of the pointers, to bullet-proof this part if anything changes in the metrics lineage in the future http://gerrit.cloudera.org:8080/#/c/21956/3/src/kudu/util/slru_cache-test.cc@302 PS3, Line 302: slru_cache_->metrics_.release() IIUC, this removes/nullifies the metrics from under the slru_cache_ instance. Is this really the desired behavior? -- To view, visit http://gerrit.cloudera.org:8080/21956 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d2fd44169e1abe642c11e16e4b87aaa971b2d88 Gerrit-Change-Number: 21956 Gerrit-PatchSet: 3 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Mon, 28 Oct 2024 19:41:10 +0000 Gerrit-HasComments: Yes
