Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21956 )
Change subject: KUDU-613: Fix minor metrics related bug ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/21956/3/src/kudu/util/slru_cache-test.cc File src/kudu/util/slru_cache-test.cc: http://gerrit.cloudera.org:8080/#/c/21956/3/src/kudu/util/slru_cache-test.cc@301 PS3, Line 301: nter > nit: consider using down_cast<> and asserting on the non-null of the result Done http://gerrit.cloudera.org:8080/#/c/21956/3/src/kudu/util/slru_cache-test.cc@302 PS3, Line 302: ld is now null. > IIUC, this removes/nullifies the metrics from under the slru_cache_ instanc That was my reservation about this approach but I haven't found another way to access the segment-level metrics in the test. Given it's a unique pointer, it must be released to be accessed here. I guess it's ok to do so since this is a test. I'll add a comment in the test about this behavior. -- To view, visit http://gerrit.cloudera.org:8080/21956 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d2fd44169e1abe642c11e16e4b87aaa971b2d88 Gerrit-Change-Number: 21956 Gerrit-PatchSet: 4 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Mon, 28 Oct 2024 20:27:31 +0000 Gerrit-HasComments: Yes
