Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21956 )
Change subject: KUDU-613: Fix minor metrics related bug ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/21956/3/src/kudu/util/slru_cache-test.cc File src/kudu/util/slru_cache-test.cc: http://gerrit.cloudera.org:8080/#/c/21956/3/src/kudu/util/slru_cache-test.cc@302 PS3, Line 302: slru_cache_->metrics_.release() > That was my reservation about this approach but I haven't found another way The crucial point is: why to call 'release()' on the segment's metrics and remove it from under the segment? Would it suffice to have a raw pointer in the test, capturing it using 'get()' method instead? -- To view, visit http://gerrit.cloudera.org:8080/21956 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d2fd44169e1abe642c11e16e4b87aaa971b2d88 Gerrit-Change-Number: 21956 Gerrit-PatchSet: 3 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Tue, 29 Oct 2024 00:21:04 +0000 Gerrit-HasComments: Yes
