Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/22009 )
Change subject: KUDU-3623 do not crash on invalid input for 'kudu table copy' ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/22009/1/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/22009/1/src/kudu/tools/kudu-tool-test.cc@6114 PS1, Line 6114: just a single tablet server started nit: capitalize comment and add period at end. http://gerrit.cloudera.org:8080/#/c/22009/1/src/kudu/tools/table_scanner.cc File src/kudu/tools/table_scanner.cc: http://gerrit.cloudera.org:8080/#/c/22009/1/src/kudu/tools/table_scanner.cc@287 PS1, Line 287: IsDouble I know it's not within the scope of this patch, but should this be IsFloat()? I did take a look at the code and I don't see such a method, but I'm curious as to why we have different methods for int and int64 but use the same one for float and double. http://gerrit.cloudera.org:8080/#/c/22009/1/src/kudu/tools/table_scanner.cc@318 PS1, Line 318: &kudu_value nit: error handling for this value? -- To view, visit http://gerrit.cloudera.org:8080/22009 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I96ee4c38f3074b44ce89ac1b18784058e9148daf Gerrit-Change-Number: 22009 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Fri, 01 Nov 2024 20:18:35 +0000 Gerrit-HasComments: Yes
