Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22009 )
Change subject: KUDU-3623 do not crash on invalid input for 'kudu table copy' ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/22009/1/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/22009/1/src/kudu/tools/kudu-tool-test.cc@6114 PS1, Line 6114: just a single tablet server started > nit: capitalize comment and add period at end. Done http://gerrit.cloudera.org:8080/#/c/22009/1/src/kudu/tools/table_scanner.cc File src/kudu/tools/table_scanner.cc: http://gerrit.cloudera.org:8080/#/c/22009/1/src/kudu/tools/table_scanner.cc@287 PS1, Line 287: IsDouble > I know it's not within the scope of this patch, but should this be IsFloat( That's a good point. I kept it as-is since I wasn't focusing on RapidJson-related peculiarities. However, after looking into the code a bit more closely, I think it's make sense to start using IsFloat() and GetFloat() here instead. Thanks! http://gerrit.cloudera.org:8080/#/c/22009/1/src/kudu/tools/table_scanner.cc@318 PS1, Line 318: &kudu_value > nit: error handling for this value? Which error handling specifically? There is RETURN_NOT_OK around ParseValue() that handles errors of parsing and converting a JSON object into a KuduValue instance. http://gerrit.cloudera.org:8080/#/c/22009/1/src/kudu/tools/table_scanner.cc@469 PS1, Line 469: top-level predicate > Maybe call this "predicate operator" to align with our documentation? Done -- To view, visit http://gerrit.cloudera.org:8080/22009 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I96ee4c38f3074b44ce89ac1b18784058e9148daf Gerrit-Change-Number: 22009 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Fri, 01 Nov 2024 21:37:26 +0000 Gerrit-HasComments: Yes
