Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/22009 )
Change subject: KUDU-3623 do not crash on invalid input for 'kudu table copy' ...................................................................... Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/22009/1/src/kudu/tools/table_scanner.cc File src/kudu/tools/table_scanner.cc: http://gerrit.cloudera.org:8080/#/c/22009/1/src/kudu/tools/table_scanner.cc@318 PS1, Line 318: &kudu_value > Which error handling specifically? There is RETURN_NOT_OK around ParseValu Took a closer look, looks like kudu_value will be set unless a Status that isn't OK is returned and that will be handled by RETURN_NOT_OK. So it looks good then, thanks. -- To view, visit http://gerrit.cloudera.org:8080/22009 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I96ee4c38f3074b44ce89ac1b18784058e9148daf Gerrit-Change-Number: 22009 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Fri, 01 Nov 2024 21:44:00 +0000 Gerrit-HasComments: Yes
