Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/22016 )
Change subject: [tablet] use STL-based atomics in MemRowSet and MRSRow ...................................................................... Patch Set 1: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/22016/1/src/kudu/tablet/memrowset.cc File src/kudu/tablet/memrowset.cc: http://gerrit.cloudera.org:8080/#/c/22016/1/src/kudu/tablet/memrowset.cc@223 PS1, Line 223: live_row_count_.fetch_add(1, std::memory_order_relaxed); [nit] Maybe add a comment that AnchorIfMinimum contains a lock, which ensures that writes are fully published, so "relaxed" is enough. I think the existing comment in the next change (in MemRowSet::Reinsert) helps a lot with code readability. http://gerrit.cloudera.org:8080/#/c/22016/1/src/kudu/tablet/memrowset.cc@292 PS1, Line 292: live_row_count_.fetch_sub(1, std::memory_order_relaxed); [nit] Same as above, I think a comment would be good. -- To view, visit http://gerrit.cloudera.org:8080/22016 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9b85fc07b4c81bc3b3cf736d7f14b424ceef81a4 Gerrit-Change-Number: 22016 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Mon, 04 Nov 2024 09:17:02 +0000 Gerrit-HasComments: Yes
