Alexey Serbin has posted comments on this change. (
http://gerrit.cloudera.org:8080/22016 )
Change subject: [tablet] use STL-based atomics in MemRowSet and MRSRow
......................................................................
Patch Set 2: Verified-1
It seems this patch introduced a new data race or exposed an existing one that
might be the reason behind well-known flakiness in mt-tablet-test:
WARNING: ThreadSanitizer: data race (pid=22860)
Atomic write of size 8 at 0x7b50000a0160 by thread T48:
#0 __tsan_atomic64_store
/home/jenkins-slave/workspace/build_and_test@2/thirdparty/src/llvm-11.0.0.src/projects/compiler-rt/lib/tsan/rtl/tsan_interface_atomic.cpp:566
(mt-tablet-test+0x66a4ba)
#1 base::subtle::Release_Store(long volatile*, long)
/home/jenkins-slave/workspace/build_and_test@2/src/kudu/gutil/atomicops-internals-tsan.h:165:3
(libtablet.so+0x4a7565)
#2 Release_Store(long volatile*, long)
/home/jenkins-slave/workspace/build_and_test@2/src/kudu/gutil/atomicops.h:364:10
(libtablet.so+0x4af450)
...
Previous read of size 8 at 0x7b50000a0160 by thread T37:
#0 kudu::tablet::MRSRow::acquire_redo_head()
/home/jenkins-slave/workspace/build_and_test@2/src/kudu/tablet/memrowset.h:118:21
(libtablet.so+0x491fdf)
#1 kudu::tablet::MemRowSet::Iterator::FetchRows(kudu::RowBlock*, unsigned
long*)
/home/jenkins-slave/workspace/build_and_test@2/src/kudu/tablet/memrowset.cc:580:33
(libtablet.so+0x48e2a2)
#2 kudu::tablet::MemRowSet::Iterator::NextBlock(kudu::RowBlock*)
/home/jenkins-slave/workspace/build_and_test@2/src/kudu/tablet/memrowset.cc:524:3
(libtablet.so+0x48dd58)
#3 kudu::UnionIterator::MaterializeBlock(kudu::RowBlock*)
/home/jenkins-slave/workspace/build_and_test@2/src/kudu/common/generic_iterators.cc:1072:31
(libkudu_common.so+0x178556)
--
To view, visit http://gerrit.cloudera.org:8080/22016
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b85fc07b4c81bc3b3cf736d7f14b424ceef81a4
Gerrit-Change-Number: 22016
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <[email protected]>
Gerrit-Reviewer: Zoltan Martonka <[email protected]>
Gerrit-Reviewer: helifu <[email protected]>
Gerrit-Comment-Date: Wed, 06 Nov 2024 22:38:48 +0000
Gerrit-HasComments: No
