Zoltan Martonka has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22016 )

Change subject: [tablet] use STL-based atomics in MemRowSet and MRSRow
......................................................................


Patch Set 1:

> (1 comment)

Thank you for the explanation. It make it clear.

My only "worry" was that setting row count with relaxed ordering might reorder 
it before actually adding items to a structure (not in this case, of course). 
So, other threads might end up seeing a larger num_of_elements. Of course if it 
has metrics like usage it does not matter.


--
To view, visit http://gerrit.cloudera.org:8080/22016
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b85fc07b4c81bc3b3cf736d7f14b424ceef81a4
Gerrit-Change-Number: 22016
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <[email protected]>
Gerrit-Comment-Date: Tue, 05 Nov 2024 10:35:09 +0000
Gerrit-HasComments: No

Reply via email to