Marton Greber has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22009 )
Change subject: KUDU-3623 do not crash on invalid input for 'kudu table copy' ...................................................................... KUDU-3623 do not crash on invalid input for 'kudu table copy' This patch adds code to handle invalid input for the --predicates flag of the 'kudu table copy' tool. Now, instead of crashing on any non-expected input, the tool exists gracefully and reports an actionable error message. With that, now it's easier to understand what was wrong, correct typos/mistakes, and re-run the tool again, eventually achieving the desired goal. A new test is added to cover the newly introduced functionality. This is a follow-up to 0afeddf9e530762e0e47beb7428982763715c746. Change-Id: I96ee4c38f3074b44ce89ac1b18784058e9148daf Reviewed-on: http://gerrit.cloudera.org:8080/22009 Tested-by: Alexey Serbin <[email protected]> Reviewed-by: Zoltan Chovan <[email protected]> Reviewed-by: Marton Greber <[email protected]> --- M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/table_scanner.cc 2 files changed, 281 insertions(+), 88 deletions(-) Approvals: Alexey Serbin: Verified Zoltan Chovan: Looks good to me, but someone else must approve Marton Greber: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/22009 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I96ee4c38f3074b44ce89ac1b18784058e9148daf Gerrit-Change-Number: 22009 Gerrit-PatchSet: 5 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]>
