Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/22058 )
Change subject: WIP [docs] add information on nullable array data block ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/22058/2/docs/design-docs/cfile.md File docs/design-docs/cfile.md: http://gerrit.cloudera.org:8080/#/c/22058/2/docs/design-docs/cfile.md@120 PS2, Line 120: flatten nit: flattened http://gerrit.cloudera.org:8080/#/c/22058/2/docs/design-docs/cfile.md@123 PS2, Line 123: similar nit: similarly http://gerrit.cloudera.org:8080/#/c/22058/2/docs/design-docs/cfile.md@128 PS2, Line 128: flatten nit: flattened, likewise for all instances below here and in the examples. http://gerrit.cloudera.org:8080/#/c/22058/2/docs/design-docs/cfile.md@156 PS2, Line 156: 1101111 Does this imply that only the third array is null? Meanwhile the flattened null bitmap implies that only the second to last value is null. Why doesn't the array null bitmap reflect that as well? Likewise, why doesn't the flattened null bitmap show that the 4th value is null? Maybe I'm missing something but just wondering. -- To view, visit http://gerrit.cloudera.org:8080/22058 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8972b3791d155e102240c80012e2b87192914cd1 Gerrit-Change-Number: 22058 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <mre...@cloudera.com> Gerrit-Comment-Date: Tue, 19 Nov 2024 18:45:37 +0000 Gerrit-HasComments: Yes
