Gabriella Lotz has posted comments on this change. ( http://gerrit.cloudera.org:8080/21823 )
Change subject: [WIP] KUDU-3608: REST API for Metadata Management ...................................................................... Patch Set 17: (1 comment) http://gerrit.cloudera.org:8080/#/c/21823/17/src/kudu/master/master_path_handlers.cc File src/kudu/master/master_path_handlers.cc: http://gerrit.cloudera.org:8080/#/c/21823/17/src/kudu/master/master_path_handlers.cc@337 PS17, Line 337: *status_code = HttpStatusCode::NoContent; > why NoContent status instead of OK? the delete was successful I chose to use the 204 No Content status code for successful DELETE requests where no additional information needs to be provided to the client. This aligns with the HTTP specification, which allows DELETE methods to return 204, 200, or 202. https://developer.mozilla.org/en-US/docs/Web/HTTP/Methods/DELETE -- To view, visit http://gerrit.cloudera.org:8080/21823 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I67f964c4f950edfde31772cafd5c3ed5d6b87413 Gerrit-Change-Number: 21823 Gerrit-PatchSet: 17 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Wed, 04 Dec 2024 14:12:27 +0000 Gerrit-HasComments: Yes
