Marton Greber has posted comments on this change. (
http://gerrit.cloudera.org:8080/21823 )
Change subject: [WIP] KUDU-3608: REST API for Metadata Management
......................................................................
Patch Set 18:
Take1: Overall the patch is in nice shape IMO.
I would +1 on Zoltans comment to add a flag to enable/disable the rest
endpoints.
My other observation is that it would be probably good to separate out the rest
catalog logic into a separate file.
One way to do this:
in master.cc we have
"""
if (web_server_) {
RETURN_NOT_OK(path_handlers_->Register(web_server_.get()));
}
"""
so if you separate out the rest catalog path handlers into a
rest_catalog_path_handlers.{h/cc}, based on the flag you just need to add
another condition to the above piece of code.
In master.cc on the top of the file you can see how gflags are defined.
Let me know if you need help with the refactor. And I will also examine the
tests in the meantime.
--
To view, visit http://gerrit.cloudera.org:8080/21823
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I67f964c4f950edfde31772cafd5c3ed5d6b87413
Gerrit-Change-Number: 21823
Gerrit-PatchSet: 18
Gerrit-Owner: Gabriella Lotz <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Gabriella Lotz <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
Gerrit-Reviewer: Zoltan Chovan <[email protected]>
Gerrit-Comment-Date: Mon, 09 Dec 2024 10:34:51 +0000
Gerrit-HasComments: No
