Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/21823 )
Change subject: [WIP] KUDU-3608: REST API for Metadata Management ...................................................................... Patch Set 18: (3 comments) http://gerrit.cloudera.org:8080/#/c/21823/17/src/kudu/master/master_path_handlers.cc File src/kudu/master/master_path_handlers.cc: http://gerrit.cloudera.org:8080/#/c/21823/17/src/kudu/master/master_path_handlers.cc@337 PS17, Line 337: jw.Protobuf(l.data().pb.schema()); > I chose to use the 204 No Content status code for successful DELETE request okay, makes sense, thanks for the clarification! http://gerrit.cloudera.org:8080/#/c/21823/18/src/kudu/master/master_path_handlers.cc File src/kudu/master/master_path_handlers.cc: http://gerrit.cloudera.org:8080/#/c/21823/18/src/kudu/master/master_path_handlers.cc@82 PS18, Line 82: #define RETURN_JSON_ERROR(jw, error_msg, status_code, error_code) \ add #undef RETURN_JSON_ERROR at the end of the file so that this macro is only present for this file http://gerrit.cloudera.org:8080/#/c/21823/18/src/kudu/master/rest_catalog-test.cc File src/kudu/master/rest_catalog-test.cc: http://gerrit.cloudera.org:8080/#/c/21823/18/src/kudu/master/rest_catalog-test.cc@112 PS18, Line 112: std::string kTableSchema = Substitute("{\"columns\":[$0]}", columns); these strings can be const as well -- To view, visit http://gerrit.cloudera.org:8080/21823 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I67f964c4f950edfde31772cafd5c3ed5d6b87413 Gerrit-Change-Number: 21823 Gerrit-PatchSet: 18 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Thu, 05 Dec 2024 08:14:48 +0000 Gerrit-HasComments: Yes
