Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22158 )
Change subject: [countdown_latch] KUDU-3631 Add lock ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/22158/4//COMMIT_MSG Commit Message: PS4: Instead of adding this extra lock and complicating a very simple thing, wouldn't it be easier to simply fix the way how the CountDownLatch class is used in one particular case? Could the problem be addressed by simply joining master's expired_reserved_tables_deleter_thread_ in Master::ShutdownImpl() method along with other threads? -- To view, visit http://gerrit.cloudera.org:8080/22158 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iebcdd22dca27c4b0dcbeecf7d87e88c923eedaa8 Gerrit-Change-Number: 22158 Gerrit-PatchSet: 4 Gerrit-Owner: Ádám Bakai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Thu, 12 Dec 2024 07:21:52 +0000 Gerrit-HasComments: Yes
