Ádám Bakai has posted comments on this change. ( http://gerrit.cloudera.org:8080/22158 )
Change subject: KUDU-3631 Fix Master shutdown ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/22158/4//COMMIT_MSG Commit Message: PS4: > Instead of adding this extra lock and complicating a very simple thing, wou You are correct, it looks like it solves the problem as well. http://gerrit.cloudera.org:8080/#/c/22158/4//COMMIT_MSG@7 PS4, Line 7: countdown_latch > nit: you can just use [util] here instead and expand a bit in the subject ( Done http://gerrit.cloudera.org:8080/#/c/22158/4/src/kudu/util/countdown_latch.h File src/kudu/util/countdown_latch.h: http://gerrit.cloudera.org:8080/#/c/22158/4/src/kudu/util/countdown_latch.h@133 PS4, Line 133: mutable std::shared_timed_mutex destruction_lock_; > Why do we need a separate mutex for this? Can't we just use lock_? My idea was that we needed a separate lock because that lock was causing the TSAN error. But the patch was reworked to solve the thread issue itself. -- To view, visit http://gerrit.cloudera.org:8080/22158 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iebcdd22dca27c4b0dcbeecf7d87e88c923eedaa8 Gerrit-Change-Number: 22158 Gerrit-PatchSet: 4 Gerrit-Owner: Ádám Bakai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Reviewer: Ádám Bakai <[email protected]> Gerrit-Comment-Date: Wed, 18 Dec 2024 14:02:05 +0000 Gerrit-HasComments: Yes
