Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22158 )
Change subject: KUDU-3631 Fix Master shutdown ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/22158/4//COMMIT_MSG Commit Message: PS4: > You are correct, it looks like it solves the problem as well. Thanks a lot for verifying and updating this patch accordingly! http://gerrit.cloudera.org:8080/#/c/22158/5/src/kudu/master/master.cc File src/kudu/master/master.cc: http://gerrit.cloudera.org:8080/#/c/22158/5/src/kudu/master/master.cc@551 PS5, Line 551: // 3. Shut down generic subsystems. Since the expired_reserved_tables_deleter_thread_ is started conditionally (see Master::StartAsync()), expired_reserved_tables_deleter_thread_ might be nullptr. In such cases this code leads to a crash, and you could see it's happening in pre-commit tests for PS5. Please update this code as necessary. Also, consider adding a comment on the reason for resetting stop_background_threads_latch_ -- it'd make this code easier to comprehend for the readers without a lot of background on the internals of the Master class. -- To view, visit http://gerrit.cloudera.org:8080/22158 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iebcdd22dca27c4b0dcbeecf7d87e88c923eedaa8 Gerrit-Change-Number: 22158 Gerrit-PatchSet: 4 Gerrit-Owner: Ádám Bakai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Reviewer: Ádám Bakai <[email protected]> Gerrit-Comment-Date: Thu, 19 Dec 2024 17:47:09 +0000 Gerrit-HasComments: Yes
