Gabriella Lotz has posted comments on this change. ( http://gerrit.cloudera.org:8080/22242 )
Change subject: [webserver] Add auth principal to WebRequest ...................................................................... Patch Set 2: (7 comments) http://gerrit.cloudera.org:8080/#/c/22242/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22242/1//COMMIT_MSG@7 PS1, Line 7: [webserver] Add auth principal to WebRequest : > nit: Add "[webserver]" at start Done http://gerrit.cloudera.org:8080/#/c/22242/1/src/kudu/server/webserver-test.cc File src/kudu/server/webserver-test.cc: http://gerrit.cloudera.org:8080/#/c/22242/1/src/kudu/server/webserver-test.cc@678 PS1, Line 678: // Test that > Make this static Done http://gerrit.cloudera.org:8080/#/c/22242/1/src/kudu/server/webserver-test.cc@686 PS1, Line 686: > nit: move this to the next line, and have it be at same indent as "/authn". Done http://gerrit.cloudera.org:8080/#/c/22242/1/src/kudu/server/webserver-test.cc@694 PS1, Line 694: > nit: same as above Done http://gerrit.cloudera.org:8080/#/c/22242/1/src/kudu/server/webserver.cc File src/kudu/server/webserver.cc: http://gerrit.cloudera.org:8080/#/c/22242/1/src/kudu/server/webserver.cc@675 PS1, Line 675: > nit: indent this line Done http://gerrit.cloudera.org:8080/#/c/22242/1/src/kudu/server/webserver.cc@676 PS1, Line 676: } else { : req. > nit: closing brace and else should be on same line as follows: Done http://gerrit.cloudera.org:8080/#/c/22242/1/src/kudu/util/web_callback_registry.h File src/kudu/util/web_callback_registry.h: http://gerrit.cloudera.org:8080/#/c/22242/1/src/kudu/util/web_callback_registry.h@74 PS1, Line 74: authn_princ > nit: change to "authn_principal" as that would still be a short and self-ex Done -- To view, visit http://gerrit.cloudera.org:8080/22242 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8a64fb77cfa3bb83b911afc3ebaa8bd23e860663 Gerrit-Change-Number: 22242 Gerrit-PatchSet: 2 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Fri, 20 Dec 2024 12:07:21 +0000 Gerrit-HasComments: Yes
