Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/22242 )
Change subject: [webserver] Add auth principal to WebRequest ...................................................................... Patch Set 3: (1 comment) Overall looks good to me. Just a minor comment. http://gerrit.cloudera.org:8080/#/c/22242/3/src/kudu/server/webserver-test.cc File src/kudu/server/webserver-test.cc: http://gerrit.cloudera.org:8080/#/c/22242/3/src/kudu/server/webserver-test.cc@713 PS3, Line 713: #ifndef __APPLE__ : nit: Are the following two tests (i.e. TestUnauthenticatedBadKeytab and TestUnauthenticatedRequestWithoutClientAuth) skipped for macOS due to KUDU-3533? IIUC from the description provided in KUDU-3533, only the first test case passes and any subsequent tests using SPNEGO auth type don't pass. I am wondering whether TestAuthenticatedUserPassedToHandler is running fine on macOS considering TestAuthenticated has already ran? -- To view, visit http://gerrit.cloudera.org:8080/22242 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8a64fb77cfa3bb83b911afc3ebaa8bd23e860663 Gerrit-Change-Number: 22242 Gerrit-PatchSet: 3 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Tue, 31 Dec 2024 11:16:55 +0000 Gerrit-HasComments: Yes
