Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22242 )
Change subject: [webserver] Add auth principal to WebRequest ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/22242/2/src/kudu/server/webserver-test.cc File src/kudu/server/webserver-test.cc: http://gerrit.cloudera.org:8080/#/c/22242/2/src/kudu/server/webserver-test.cc@708 PS2, Line 708: TEST_F(NoAuthnWebserverTest, TestUnauthenticatedUser) { A couple of other important cases to cover is something similar to TestUnauthenticatedBadKeytab and TestUnauthenticatedNoClientAuth: make sure the WebRequest::authn_principal is as seen expected when a user failed to authenticate. http://gerrit.cloudera.org:8080/#/c/22242/2/src/kudu/server/webserver-test.cc@710 PS2, Line 710: ASSERT_STR_CONTAINS(buf_.ToString(), ""); IIUC, this assert doesn't make a lot of sense since it matches anything, right? Maybe, the idea was to check the emptiness of the response? -- To view, visit http://gerrit.cloudera.org:8080/22242 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8a64fb77cfa3bb83b911afc3ebaa8bd23e860663 Gerrit-Change-Number: 22242 Gerrit-PatchSet: 2 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Tue, 24 Dec 2024 00:32:45 +0000 Gerrit-HasComments: Yes
