Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/22242 )
Change subject: [webserver] Add auth principal to WebRequest ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/22242/3/src/kudu/server/webserver-test.cc File src/kudu/server/webserver-test.cc: http://gerrit.cloudera.org:8080/#/c/22242/3/src/kudu/server/webserver-test.cc@713 PS3, Line 713: } : > I checked and these tests (TestUnauthenticatedBadKeytab and TestUnauthentic I don't want to hold this patch but I am a little bit confused. Maybe I am missing something here. I was under the impression that only the first test case (i.e. TestAuthenticated) using SPNEGO auth type is passing for macOS. And all the subsequent test cases (using SPNEGO auth type) are not which is why they are skipped for macOS. By that logic all the tests including TestAuthenticatedUserPassedToHandler need to be skipped. If you run all these newly added tests on macOS, what is the outcome for each? -- To view, visit http://gerrit.cloudera.org:8080/22242 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8a64fb77cfa3bb83b911afc3ebaa8bd23e860663 Gerrit-Change-Number: 22242 Gerrit-PatchSet: 4 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Tue, 31 Dec 2024 13:15:25 +0000 Gerrit-HasComments: Yes
