Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/22242 )
Change subject: [webserver] Add auth principal to WebRequest ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/22242/3/src/kudu/server/webserver-test.cc File src/kudu/server/webserver-test.cc: http://gerrit.cloudera.org:8080/#/c/22242/3/src/kudu/server/webserver-test.cc@713 PS3, Line 713: } : > I don't want to hold this patch but I am a little bit confused. Thanks for sharing the test results on macOS. The fact that only one test (i.e. TestAuthenticatedUserPassedToHandler) is problematic when ran with other tests is puzzling to me. I was expecting that none of these newly added tests would pass if ran with other tests on macOS. Maybe there is some gap in my understanding. Also, I noticed that KUDU-3533 is applicable to SpnegoWebserverTest cases. I will take another look to understand this. For now, maybe add a comment about the reason behind skipping newly added test for macOS. -- To view, visit http://gerrit.cloudera.org:8080/22242 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8a64fb77cfa3bb83b911afc3ebaa8bd23e860663 Gerrit-Change-Number: 22242 Gerrit-PatchSet: 4 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Tue, 31 Dec 2024 14:26:20 +0000 Gerrit-HasComments: Yes
