Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22312 )
Change subject: [docs] Elaborate rack-aware rebalancing ...................................................................... Patch Set 2: (10 comments) http://gerrit.cloudera.org:8080/#/c/22312/2/docs/administration.adoc File docs/administration.adoc: http://gerrit.cloudera.org:8080/#/c/22312/2/docs/administration.adoc@1577 PS2, Line 1577: nit for here and below: remove the trailing spaces and spaces in empty lines http://gerrit.cloudera.org:8080/#/c/22312/2/docs/administration.adoc@1589 PS2, Line 1589: /run together nit: remove this? http://gerrit.cloudera.org:8080/#/c/22312/2/docs/administration.adoc@1597 PS2, Line 1597: Example Examples http://gerrit.cloudera.org:8080/#/c/22312/2/docs/administration.adoc@1598 PS2, Line 1598: The behavior of each of the these flags can be better explained with examples. In addition to the examples in whatever their form is, does it make sense to provide a short text summary, explicitly stating the crucial property/constraint that should be observed in the result distribution of tablet replicas? http://gerrit.cloudera.org:8080/#/c/22312/2/docs/administration.adoc@1620 PS2, Line 1620: | Replica X | Replica Y | Replica Z : | Replica X | Replica Z | Replica Z : | Replica Y | Replica X | Replica Y I don't think this represents one of the correct results. The placement policy logic implemented in the tool should have reshuffled tablet replicas to protect against collocated failures. A crucial constraint for that is: not a single location should contain a majority of replicas for any of the participating tablets. In this snippet, locations 'A' and 'C' aren't conforming with the crux of the placement policy. http://gerrit.cloudera.org:8080/#/c/22312/2/docs/administration.adoc@1630 PS2, Line 1630: rebalancer_example Is it intentional to have this tag duplicated many times below? http://gerrit.cloudera.org:8080/#/c/22312/2/docs/administration.adoc@1634 PS2, Line 1634: Number of replicas It would be great to clarify: it's the total number of tablet replicas across all the tables in this location. http://gerrit.cloudera.org:8080/#/c/22312/2/docs/administration.adoc@1635 PS2, Line 1635: replicas nit: remove 'replicas' since the column title assumes there should be just a number in here http://gerrit.cloudera.org:8080/#/c/22312/2/docs/administration.adoc@1650 PS2, Line 1650: but nit: remove 'but' http://gerrit.cloudera.org:8080/#/c/22312/2/docs/administration.adoc@1679 PS2, Line 1679: and the final state can be achieved in one : single run I'm not sure this brings any clarify here. Actually, it might bring in some confusion, at least because "the final states" achieved in the end of this example and running the tool with all the three phases disabled at once should be different by definition. -- To view, visit http://gerrit.cloudera.org:8080/22312 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6724c8cdd69167fabf51b66a462dfa25338c057d Gerrit-Change-Number: 22312 Gerrit-PatchSet: 2 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Thu, 09 Jan 2025 02:41:15 +0000 Gerrit-HasComments: Yes
