Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22312 )
Change subject: [docs] Elaborate rack-aware rebalancing ...................................................................... Patch Set 4: Code-Review+1 (8 comments) It's almost there -- just a few nits that I for some reason didn't notice in the prior round of review. Thank you for working on this! http://gerrit.cloudera.org:8080/#/c/22312/4/docs/administration.adoc File docs/administration.adoc: http://gerrit.cloudera.org:8080/#/c/22312/4/docs/administration.adoc@1625 PS4, Line 1625: the below flags with the below flags http://gerrit.cloudera.org:8080/#/c/22312/4/docs/administration.adoc@1626 PS4, Line 1626: inter/cross location nit: cross-location That would be simpler and it also avoids confusion between intra- and inter-location rebalancing. http://gerrit.cloudera.org:8080/#/c/22312/4/docs/administration.adoc@1650 PS4, Line 1650: in each locations nit: 'in each of the locations' or 'in each location' http://gerrit.cloudera.org:8080/#/c/22312/4/docs/administration.adoc@1650 PS4, Line 1650: are nit: fix this w.r.t. singular/plural notion -- 'the number of replicas' seems to be singular, but 'are' is for plural? http://gerrit.cloudera.org:8080/#/c/22312/4/docs/administration.adoc@1652 PS4, Line 1652: Continuing the above example let's examine nit: add a comma? Continuing the above example, let's examine ... http://gerrit.cloudera.org:8080/#/c/22312/4/docs/administration.adoc@1653 PS4, Line 1653: intra location nit: intra-location http://gerrit.cloudera.org:8080/#/c/22312/4/docs/administration.adoc@1681 PS4, Line 1681: are nit: fix this according to singular/plural for the noun in the sentence http://gerrit.cloudera.org:8080/#/c/22312/4/docs/administration.adoc@1683 PS4, Line 1683: is nit: is --> are? Or maybe rephrase the sentence a bit, so it's talking about the usage of the flags, but not the flags themselves? -- To view, visit http://gerrit.cloudera.org:8080/22312 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6724c8cdd69167fabf51b66a462dfa25338c057d Gerrit-Change-Number: 22312 Gerrit-PatchSet: 4 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Mon, 13 Jan 2025 23:20:23 +0000 Gerrit-HasComments: Yes
