Abhishek Chennaka has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22312 )

Change subject: [docs] Elaborate rack-aware rebalancing
......................................................................


Patch Set 3:

(10 comments)

http://gerrit.cloudera.org:8080/#/c/22312/2/docs/administration.adoc
File docs/administration.adoc:

http://gerrit.cloudera.org:8080/#/c/22312/2/docs/administration.adoc@1577
PS2, Line 1577:
> nit for here and below: remove the trailing spaces and spaces in empty line
Done


http://gerrit.cloudera.org:8080/#/c/22312/2/docs/administration.adoc@1589
PS2, Line 1589:
> nit: remove this?
Done


http://gerrit.cloudera.org:8080/#/c/22312/2/docs/administration.adoc@1597
PS2, Line 1597: der a c
> Examples
Done


http://gerrit.cloudera.org:8080/#/c/22312/2/docs/administration.adoc@1598
PS2, Line 1598: total) and running the tool with the below flags (effectively 
running only the placement policy
> In addition to the examples in whatever their form is, does it make sense t
Done


http://gerrit.cloudera.org:8080/#/c/22312/2/docs/administration.adoc@1620
PS2, Line 1620: | Replica Z  | Replica Z  | Replica Z
              : |===
              :
> I don't think this represents one of the correct results.
Yes, that was an error on my part. Fixed it


http://gerrit.cloudera.org:8080/#/c/22312/2/docs/administration.adoc@1630
PS2, Line 1630: rebalancer_example
> Is it intentional to have this tag duplicated many times below?
Added more information to make each tag unique


http://gerrit.cloudera.org:8080/#/c/22312/2/docs/administration.adoc@1634
PS2, Line 1634: Number of replicas
> It would be great to clarify: it's the total number of tablet replicas acro
Done


http://gerrit.cloudera.org:8080/#/c/22312/2/docs/administration.adoc@1635
PS2, Line 1635:
> nit: remove 'replicas' since the column title assumes there should be just
Done


http://gerrit.cloudera.org:8080/#/c/22312/2/docs/administration.adoc@1650
PS2, Line 1650:  in
> nit: remove 'but'
Done


http://gerrit.cloudera.org:8080/#/c/22312/2/docs/administration.adoc@1679
PS2, Line 1679:
              :
> I'm not sure this brings any clarify here.  Actually, it might bring in som
Done



--
To view, visit http://gerrit.cloudera.org:8080/22312
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6724c8cdd69167fabf51b66a462dfa25338c057d
Gerrit-Change-Number: 22312
Gerrit-PatchSet: 3
Gerrit-Owner: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <[email protected]>
Gerrit-Comment-Date: Fri, 10 Jan 2025 19:23:04 +0000
Gerrit-HasComments: Yes

Reply via email to