Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/22253 )
Change subject: KUDU-613: Make segment metrics more relevant ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/22253/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22253/2//COMMIT_MSG@11 PS2, Line 11: stats of > nit: stats Done http://gerrit.cloudera.org:8080/#/c/22253/1/src/kudu/util/slru_cache.h File src/kudu/util/slru_cache.h: http://gerrit.cloudera.org:8080/#/c/22253/1/src/kudu/util/slru_cache.h@65 PS1, Line 65: // True if entry is in protected segment, false if not. : // Used for releasing from the right shard in the SLRU cache implementation. : std::atomic<bool> in_protected_segment; > Thanks for elaborating on this. That's a good point. The fix should be relatively simple. Before deleting the old entry, just set the new updated entry's fields to the old entry's 'upgrades' and 'downgrades' values. I'll add that, thanks for pointing this out. http://gerrit.cloudera.org:8080/#/c/22253/1/src/kudu/util/slru_cache.h@69 PS1, Line 69: int32_t > Could int32_t be implicitly converted without any issues into int64_t when I don't expect the numbers to go beyond 2^31, I think implicit conversion is ok here. Changed all of the values back to 32-bit ints. -- To view, visit http://gerrit.cloudera.org:8080/22253 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id44828be41a19593e6808debf7e9ba8e1fc4dcca Gerrit-Change-Number: 22253 Gerrit-PatchSet: 3 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Fri, 10 Jan 2025 21:44:39 +0000 Gerrit-HasComments: Yes
