Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/22253 )
Change subject: KUDU-613: Make segment metrics more relevant ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/22253/3/src/kudu/util/cache_metrics.h File src/kudu/util/cache_metrics.h: http://gerrit.cloudera.org:8080/#/c/22253/3/src/kudu/util/cache_metrics.h@45 PS3, Line 45: : scoped_refptr<Histogram> upgrades_stats; : scoped_refptr<Histogram> downgrade > Since upgrades_stats and downgrades_stats histogram metrics are now present Yep 'total_count' suffices to count the number of upgrades and downgrades. http://gerrit.cloudera.org:8080/#/c/22253/3/src/kudu/util/slru_cache.h File src/kudu/util/slru_cache.h: http://gerrit.cloudera.org:8080/#/c/22253/3/src/kudu/util/slru_cache.h@67 PS3, Line 67: std::atomic<bool> in_protected_segment; > > However, I think there is simpler way to handling this: you just need to No problem, let me know if you have any ideas on how to get rid of 'in_protected_segment', open to any ideas! http://gerrit.cloudera.org:8080/#/c/22253/3/src/kudu/util/slru_cache.h@69 PS3, Line 69: // Number of times an entry has been upgraded or downgraded. These fields are tied to the key, > Whoops, sorry -- I missed it in the prior review rounds, but it's better Done -- To view, visit http://gerrit.cloudera.org:8080/22253 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id44828be41a19593e6808debf7e9ba8e1fc4dcca Gerrit-Change-Number: 22253 Gerrit-PatchSet: 4 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Mon, 13 Jan 2025 22:58:05 +0000 Gerrit-HasComments: Yes
